PMD Results

The following document contains the results of PMD 3.9.

Files

it/imolinfo/jbi4cics/Logger.java

Violation Line
Avoid variables with short names like t 33
Avoid variables with short names like t 47
Avoid variables with short names like t 61
Avoid variables with short names like t 75

it/imolinfo/jbi4cics/commareaparser/OccursDefinition.java

Violation Line
Avoid excessively long variable names like cobolTypeDescriptor 88

it/imolinfo/jbi4cics/commareaparser/PictureDefinition.java

Violation Line
Avoid excessively long variable names like cobolTypeDescriptor 122

it/imolinfo/jbi4cics/configuration/ConfigurationManager.java

Violation Line
Avoid excessively long variable names like theConfigurationManager 21

it/imolinfo/jbi4cics/connection/ConnectionManagerFactory.java

Violation Line
Avoid excessively long variable names like cicsConnectionManager 32
Avoid excessively long variable names like imsConnectionManager 33
Avoid excessively long variable names like jdbcConnectionManager 34
Avoid excessively long variable names like echoConnectionManager 35

it/imolinfo/jbi4cics/connection/jca/CommareaRecord.java

Violation Line
Avoid excessively long variable names like recordShortDescription 42
Avoid variables with short names like is 72
Avoid variables with short names like os 82

it/imolinfo/jbi4cics/connection/jca/JCAAbstractConnectionManager.java

Violation Line
Abstract classes should be named AbstractXXX 34 - 208
Avoid excessively long variable names like jndiConnectionName 141

it/imolinfo/jbi4cics/connection/jca/JCACommareaBasedConnectionManager.java

Violation Line
Abstract classes should be named AbstractXXX 28 - 105
Avoid excessively long variable names like outputMappingDescriptor 68

it/imolinfo/jbi4cics/connection/jca/cics/CICSConnectionManager.java

Violation Line
The class 'CICSConnectionManager' has a Cyclomatic Complexity of 5 (Highest = 10). 33 - 253
The String literal "CIC000400_Error_istantiating_connection_spec" appears 12 times in this file; the first occurrence is on line 69 69
The method 'createInteractionSpec' has a Cyclomatic Complexity of 10. 107 - 191
Avoid excessively long variable names like cicsInteractionDescription 113
Avoid excessively long variable names like eciInteractionSpec 115
The String literal "CIC000401_Expected_commarea_bean_mapping_descriptor" appears 4 times in this file; the first occurrence is on line 160 160
Avoid excessively long variable names like inputMappingDescriptor 167
Avoid excessively long variable names like outputMappingDescriptor 168
The String literal "CIC000403_Method_invocation_error" appears 12 times in this file; the first occurrence is on line 211 211

it/imolinfo/jbi4cics/connection/jca/ims/IMSConnectionManager.java

Violation Line
Avoid excessively long variable names like imsInteractionSpec 43
The String literal "CIC000500_Error_istantiating_connection_spec" appears 12 times in this file; the first occurrence is on line 49 49
Avoid empty if statements 65 - 80
Avoid empty if statements 108 - 122

it/imolinfo/jbi4cics/connection/jdbc/JdbcConnectionManager.java

Violation Line
Avoid excessively long variable names like disconnectedStatement 56
Avoid excessively long variable names like jdbcStatementDescriptor 72
Avoid excessively long variable names like jndiConnectionName 126
Avoid excessively long variable names like disconnectedPreparedStatement 149

it/imolinfo/jbi4cics/connection/jdbc/util/CallableStatementInvocationHandler.java

Violation Line
Avoid excessively long variable names like parameterIndexList 45
Avoid excessively long variable names like nameValueParamterMap 46
Avoid excessively long variable names like indexValueParamterMap 47
Avoid excessively long variable names like resultSetConcurrency 62
Avoid excessively long variable names like resultSetConcurrency 73
Avoid excessively long variable names like resultSetHoldability 73

it/imolinfo/jbi4cics/connection/jdbc/util/DisconnectedStatementFactory.java

Violation Line
Avoid excessively long variable names like resultSetConcurrency 37
Avoid excessively long variable names like resultSetConcurrency 41
Avoid excessively long variable names like resultSetHoldability 41
Avoid excessively long variable names like resultSetConcurrency 57
Avoid excessively long variable names like resultSetConcurrency 61
Avoid excessively long variable names like resultSetHoldability 61
Avoid excessively long variable names like resultSetConcurrency 73
Avoid excessively long variable names like resultSetConcurrency 77
Avoid excessively long variable names like resultSetHoldability 77

it/imolinfo/jbi4cics/connection/jdbc/util/PreparedStatementInvocationHandler.java

Violation Line
Avoid excessively long variable names like resultSetConcurrency 60
Avoid excessively long variable names like resultSetConcurrency 71
Avoid excessively long variable names like resultSetHoldability 71

it/imolinfo/jbi4cics/connection/jdbc/util/StatementInvocationHandler.java

Violation Line
Avoid excessively long variable names like underlyingStatement 56
Avoid excessively long variable names like resultSetConcurrency 63
Avoid excessively long variable names like resultSetHoldability 64
Avoid excessively long variable names like resultSetConcurrency 77
Avoid excessively long variable names like resultSetConcurrency 88
Avoid excessively long variable names like resultSetHoldability 88

it/imolinfo/jbi4cics/jbi/BaseBootstrap.java

Violation Line
A method/constructor shouldn't explicitly throw java.lang.Exception 84
A method/constructor shouldn't explicitly throw java.lang.Exception 88
A method/constructor shouldn't explicitly throw java.lang.Exception 132
A method/constructor shouldn't explicitly throw java.lang.Exception 181
A method/constructor shouldn't explicitly throw java.lang.Exception 222
A method/constructor shouldn't explicitly throw java.lang.Exception 252

it/imolinfo/jbi4cics/jbi/Jbi4cicsComponentConfiguration.java

Violation Line
Avoid excessively long variable names like fakeBooleanProperty 17
Avoid excessively long variable names like fakeBooleanProperty 26

it/imolinfo/jbi4cics/jbi/Jbi4cicsConfigurationMBean.java

Violation Line
Avoid excessively long variable names like fakeBooleanProperty 12

it/imolinfo/jbi4cics/jbi/Jbi4cicsEndpoint.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 10 - 501
Avoid excessively long variable names like outputCopyCobolFileName 77
A method/constructor shouldn't explicitly throw java.lang.Exception 124
A method/constructor shouldn't explicitly throw java.lang.Exception 136
Avoid excessively long variable names like outputCopyCobolFileName 480

it/imolinfo/jbi4cics/jbi/Jbi4cicsExchangeProcessor.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 8 - 274
The class 'Jbi4cicsExchangeProcessor' has a Cyclomatic Complexity of 4 (Highest = 17). 55 - 274
Avoid unused private fields such as 'MESSAGES'. 66
Avoid excessively long variable names like SOAP_FAULT_SUBCODE 70
A method/constructor shouldn't explicitly throw java.lang.Exception 84
The method process() has an NPath complexity of 792 84 - 222
Avoid really long methods. 84 - 222
The method 'process' has a Cyclomatic Complexity of 17. 84 - 222
Avoid variables with short names like t 98
Avoid variables with short names like c 100
Avoid variables with short names like op 109
Avoid variables with short names like in 115
Avoid variables with short names like dh 149
Avoid throwing raw exception types. 182
Avoid variables with short names like op 200
A method/constructor shouldn't explicitly throw java.lang.Exception 224
A method/constructor shouldn't explicitly throw java.lang.Exception 228

it/imolinfo/jbi4cics/jbi/Jbi4cicsLifeCycle.java

Violation Line
A method/constructor shouldn't explicitly throw java.lang.Exception 56

it/imolinfo/jbi4cics/jbi/Jbi4cicsWSDLDeployer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 10 - 569

it/imolinfo/jbi4cics/jbi/Messages.java

Violation Line
Avoid excessively long variable names like BUNDLE_NAME_SUFFIX 39
String.indexOf(char) is faster than String.indexOf(String). 160

it/imolinfo/jbi4cics/jbi/processor/wsdl11wrapper/WrapperProcessingException.java

Violation Line
No need to import a type that lives in the same package 33

it/imolinfo/jbi4cics/jbi/processor/wsdl11wrapper/WrapperUtil.java

Violation Line
Avoid excessively long variable names like WRAPPER_DEFAULT_NAMESPACE_PREFIX 58
Avoid excessively long variable names like WRAPPER_DEFAULT_NAMESPACE 60
Avoid excessively long variable names like WRAPPER_ATTRIBUTE_VERSION 64
Avoid excessively long variable names like WRAPPER_ATTRIBUTE_VERSION_VALUE 66
Avoid excessively long variable names like WRAPPER_ATTRIBUTE_TYPE 68
Avoid excessively long variable names like WRAPPER_ATTRIBUTE_NAME 70
Avoid unused local variables such as 'normalRoot'. 263
The String literal "UTF-8" appears 4 times in this file; the first occurrence is on line 300 300
Avoid excessively long variable names like omitXMLDeclaration 320

it/imolinfo/jbi4cics/jbi/wsdl/Jbi4CicsAddress.java

Violation Line
Avoid excessively long variable names like JNDIConnectionName 42

it/imolinfo/jbi4cics/jbi/wsdl/Jbi4CicsAddressDeserializer.java

Violation Line
Avoid variables with short names like el 45

it/imolinfo/jbi4cics/jbi/wsdl/Jbi4CicsAddressSerializer.java

Violation Line
The class 'Jbi4CicsAddressSerializer' has a Cyclomatic Complexity of 8 (Highest = 13). 33 - 171
The method marshall() has an NPath complexity of 1156 62 - 169
Avoid really long methods. 62 - 169
The method 'marshall' has a Cyclomatic Complexity of 13. 62 - 169
Avoid variables with short names like pw 63

it/imolinfo/jbi4cics/jbi/wsdl/Jbi4CicsBindingSerializer.java

Violation Line
The String literal ">\n" appears 4 times in this file; the first occurrence is on line 160 160
String.trim().length()==0 is an inefficient way to validate an empty String. 173

it/imolinfo/jbi4cics/jbi/wsdl/Jbi4CicsExtension.java

Violation Line
Avoid excessively long variable names like COPY_COBOL_ELEMENT 37
Avoid excessively long variable names like OUTPUT_COPY_COBOL_ELEMENT 38
Avoid excessively long variable names like SERVICE_PACKAGE_NAME_ATTRIBUTE 39
Avoid excessively long variable names like CODE_PAGE_NAME_ATTRIBUTE 40
Avoid excessively long variable names like SAME_COPY_COBOL_ATTRIBUTE 41
Avoid excessively long variable names like USERNAME_ATTRIBUTE 42
Avoid excessively long variable names like PASSWORD_ATTRIBUTE 43
Avoid excessively long variable names like CONNECTION_TYPE_ATTRIBUTE 44
Avoid excessively long variable names like JNDI_CONNECTION_NAME_ATTRIBUTE 45
Avoid excessively long variable names like PROGRAM_NAME_ATTRIBUTE 46
Avoid excessively long variable names like TRANSACTION_NAME_ATTRIBUTE 47
Avoid excessively long variable names like Q_ELEM_JBI4CICS_BINDING 53
Avoid excessively long variable names like Q_ELEM_JBI4CICS_ADDRESS 59
Avoid excessively long variable names like Q_ELEM_JBI4CICS_COPY_COBOL 66
Avoid excessively long variable names like Q_ELEM_JBI4CICS_OUTPUT_COPY_COBOL 72

it/imolinfo/jbi4cics/jbi/xfire/JbiChannel.java

Violation Line
The class 'JbiChannel' has a Cyclomatic Complexity of 4 (Highest = 10). 45 - 157
Avoid excessively long variable names like JBI_INTERFACE_NAME 47
A method/constructor shouldn't explicitly throw java.lang.Exception 73
The method 'send' has a Cyclomatic Complexity of 10. 76 - 135
Avoid variables with short names like me 95
Avoid empty if statements 123 - 125

it/imolinfo/jbi4cics/jbi/xfire/JbiTransport.java

Violation Line
Avoid variables with short names like c 67

it/imolinfo/jbi4cics/locator/SimpleLocation.java

Violation Line
Avoid excessively long variable names like connectionTypeName 94

it/imolinfo/jbi4cics/messageformat/MessageFormatterFactory.java

Violation Line
Avoid excessively long variable names like toStringMessageFormatter 27
Avoid excessively long variable names like noOpMessageFormatter 28

it/imolinfo/jbi4cics/messageformat/NoOpMappingDescriptor.java

Violation Line
Avoid excessively long variable names like superClassProperties 58
Avoid excessively long variable names like superClassPropertyList 62
Avoid excessively long variable names like classPropertyListCopy 65
Avoid excessively long variable names like superClassProperty 70

it/imolinfo/jbi4cics/messageformat/commarea/CommareaFormatter.java

Violation Line
The String literal "CIC001702_Expected_commarea_bean_mapping_descriptor" appears 4 times in this file; the first occurrence is on line 60 60

it/imolinfo/jbi4cics/messageformat/commarea/NestingHandler.java

Violation Line
The class 'NestingHandler' has a Cyclomatic Complexity of 10 (Highest = 9). 21 - 99
Avoid excessively long variable names like commareaBeanMappingDescriptor 36
Avoid excessively long variable names like currentCommareaBeanMappingDescriptor 38
Avoid excessively long variable names like cobolTypeDescriptor 47

it/imolinfo/jbi4cics/messageformat/jdbc/JdbcBeanMappingDescriptor.java

Violation Line
Avoid excessively long variable names like jdbcStatementDescriptor 32
Avoid excessively long variable names like resultSetMappingDescriptor 33
Avoid excessively long variable names like resultSetPropertyName 34
Avoid excessively long variable names like resultSetPropertyName 53
Avoid excessively long variable names like jdbcStatementDescriptor 69
Avoid excessively long variable names like resultSetMappingDescriptor 105

it/imolinfo/jbi4cics/messageformat/jdbc/JdbcFormatter.java

Violation Line
The class 'JdbcFormatter' has a Cyclomatic Complexity of 8 (Highest = 16). 39 - 228
Avoid excessively long variable names like jdbcStatementDescriptor 75
Avoid excessively long variable names like propertyNameParameterIndexMap 94
Avoid excessively long variable names like jdbcParameterDescriptor 100
The method mapOutputMessageToOutputBean() has an NPath complexity of 648 121 - 226
Avoid really long methods. 121 - 226
The method 'mapOutputMessageToOutputBean' has a Cyclomatic Complexity of 16. 121 - 226
Avoid excessively long variable names like jdbcBeanMappingDescriptor 131
Avoid excessively long variable names like jdbcStatementDescriptor 132
Avoid excessively long variable names like resultSetMappingDescriptor 133
Avoid excessively long variable names like wrappedOutputParameterBean 145
Avoid excessively long variable names like propertyNameParameterIndexMap 162
Avoid excessively long variable names like disconnectedCallableStatement 163
Avoid excessively long variable names like jdbcParameterDescriptor 168
Avoid excessively long variable names like outputResultSetBeanList 183
Avoid excessively long variable names like resultSetDynaClass 187
Avoid excessively long variable names like wrappedOutputResultSetBean 192
Avoid excessively long variable names like columnNamePropertyNameMap 206

it/imolinfo/jbi4cics/messageformat/jdbc/JdbcOutputMessage.java

Violation Line
Avoid excessively long variable names like disconnectedSatetement 22
Avoid excessively long variable names like disconnectedSatetement 28
Avoid excessively long variable names like disconnectedSatetement 53

it/imolinfo/jbi4cics/messageformat/jdbc/JdbcStatementDescriptor.java

Violation Line
Avoid excessively long variable names like PREPARED_STATEMENT 22
Avoid excessively long variable names like CALLABLE_STATEMENT 23
Avoid excessively long variable names like propertyNameParameterIndexMap 45

it/imolinfo/jbi4cics/messageformat/jdbc/ResultSetMappingDescriptor.java

Violation Line
Avoid excessively long variable names like columnNamePropertyNameMap 27

it/imolinfo/jbi4cics/service/ServiceContext.java

Violation Line
Avoid excessively long variable names like inputMappingDescriptor 30
Avoid excessively long variable names like outputMappingDescriptor 31
Avoid excessively long variable names like interactionDescription 32
Avoid excessively long variable names like interactionDescription 51
Avoid excessively long variable names like outputMappingDescriptor 183

it/imolinfo/jbi4cics/service/ServiceManager.java

Violation Line
Avoid excessively long variable names like configurationManager 40
Avoid excessively long variable names like inputMessageFormatter 65
Avoid excessively long variable names like outputMessageFormatter 77

it/imolinfo/jbi4cics/typemapping/cobol/CobolFieldFormatter.java

Violation Line
Avoid variables with short names like ct 55
The String literal "CIC002102_Unrecognized_cobol_type" appears 4 times in this file; the first occurrence is on line 58 58
The String literal "CIC002107_Number_not_found" appears 6 times in this file; the first occurrence is on line 134 134

it/imolinfo/jbi4cics/typemapping/cobol/CobolTypeDescriptor.java

Violation Line
Avoid excessively long variable names like STRING_JUSTIFICATION_LEFT 31
Avoid excessively long variable names like STRING_JUSTIFICATION_RIGHT 33
Avoid excessively long variable names like STRING_JUSTIFICATION_CENTER 35
Avoid excessively long variable names like SIGN_FORMAT_LEADING 41
Avoid excessively long variable names like SIGN_FORMAT_TRAILING 43
Avoid excessively long variable names like SIGN_FORMAT_LEADING_SEPARATE 45
Avoid variables with short names like ct 310
Avoid variables with short names like ct 350
Avoid variables with short names like ct 389

it/imolinfo/jbi4cics/typemapping/cobol/HexDump.java

Violation Line
The class 'HexDump' has a Cyclomatic Complexity of 3 (Highest = 12). 35 - 433
The method dump() has an NPath complexity of 300 86 - 156
The method 'dump' has a Cyclomatic Complexity of 12. 86 - 156
The String literal "CIC002112_Illegal_index" appears 4 times in this file; the first occurrence is on line 99 99
The method 'dump' has a Cyclomatic Complexity of 10. 195 - 243
Avoid variables with short names like i 310
Avoid variables with short names like in 389
Avoid variables with short names like c 394
Avoid variables with short names like c 406
A method/constructor shouldn't explicitly throw java.lang.Exception 425
Avoid variables with short names like in 427
Avoid variables with short names like b 428

it/imolinfo/jbi4cics/typemapping/cobol/PackedDecimalMarshaller.java

Violation Line
Don't create instances of already existing BigInteger and BigDecimal (ZERO, ONE, TEN) 54
Avoid calling toString() on String objects; this is unnecessary. 70

it/imolinfo/jbi4cics/typemapping/cobol/StringMarshaller.java

Violation Line
The String literal "CIC002116_Code_page_not_supported" appears 6 times in this file; the first occurrence is on line 42 42

it/imolinfo/jbi4cics/typemapping/cobol/ZonedMarshaller.java

Violation Line
The class 'ZonedMarshaller' has a Cyclomatic Complexity of 11 (Highest = 16). 18 - 132
Avoid excessively long variable names like virtualDecimalPoint 42
The method marshallZoned() has an NPath complexity of 720 42 - 93
The method 'marshallZoned' has a Cyclomatic Complexity of 16. 42 - 93
Don't create instances of already existing BigInteger and BigDecimal (ZERO, ONE, TEN) 50
Avoid excessively long variable names like dataStartingOffset 67
Avoid excessively long variable names like virtualDecimalPoint 94
The method unmarshallZoned() has an NPath complexity of 450 94 - 130
The method 'unmarshallZoned' has a Cyclomatic Complexity of 16. 94 - 130
Avoid excessively long variable names like dataStartingOffset 96

it/imolinfo/jbi4cics/webservices/descriptor/ServiceDescriptor.java

Violation Line
Avoid excessively long variable names like serviceInterfaceName 31
Avoid excessively long variable names like inputBeanClassName 32
Avoid excessively long variable names like outputBeanClassName 33
Avoid excessively long variable names like serviceInterfacePackageName 34
Avoid excessively long variable names like inputMappingDescriptor 41
Avoid excessively long variable names like outputMappingDescriptor 42
Avoid excessively long variable names like interactionDescription 45
Avoid excessively long variable names like inputMappingDescriptor 135
Avoid excessively long variable names like interactionDescription 149
Avoid excessively long variable names like outputMappingDescriptor 163
Avoid excessively long variable names like serviceInterfaceName 205
Avoid excessively long variable names like serviceInterfacePackageName 219
Avoid excessively long variable names like inputBeanClassName 247
Avoid excessively long variable names like outputBeanClassName 261

it/imolinfo/jbi4cics/webservices/runtime/ServiceCreator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 10 - 414

it/imolinfo/jbi4cics/webservices/runtime/ServiceInvoker.java

Violation Line
Avoid excessively long variable names like inputMessageFormatter 71
Avoid excessively long variable names like outputMessageFormatter 112

it/imolinfo/jbi4cics/webservices/utils/generators/ServiceBeanGenerator.java

Violation Line
Avoid excessively long variable names like cobolTypeDescriptor 118
The String literal "CIC002400_Class_generation_error" appears 4 times in this file; the first occurrence is on line 149 149
Avoid variables with short names like mv 173
Avoid variables with short names like mv 198
Avoid variables with short names like mv 220
Avoid variables with short names like mv 243
Avoid variables with short names like fv 262
Avoid variables with short names like mv 280
Avoid variables with short names like mv 306

it/imolinfo/jbi4cics/webservices/utils/generators/ServiceInterfaceGenerator.java

Violation Line
Avoid variables with short names like cw 59
Avoid variables with short names like mv 64

org/slf4j/impl/JDK14LoggerAdapter.java

Violation Line
Avoid variables with short names like t 236
Avoid variables with short names like t 321
Avoid variables with short names like t 408
Avoid variables with short names like t 495
Avoid variables with short names like t 514
Avoid throwing raw exception types. 533
Avoid variables with short names like t 572
Avoid variables with short names like t 617
Avoid variables with short names like t 638
Avoid variables with short names like t 657
Avoid variables with short names like t 676

org/slf4j/impl/Log4jLoggerAdapter.java

Violation Line
Avoid variables with short names like t 234
Avoid variables with short names like t 323
Avoid variables with short names like t 412
Avoid variables with short names like t 503
Avoid variables with short names like t 519
Avoid variables with short names like t 564
Avoid variables with short names like t 587
Avoid variables with short names like t 606
Avoid variables with short names like t 625

org/slf4j/impl/StaticLoggerBinder.java

Violation Line
Avoid excessively long variable names like LOGGER_FACTORY_CLASS_STR 64